feat(review): scope reviews by pull request#261
Open
Vaibhaav-Tiwari wants to merge 2 commits into
Open
Conversation
Collaborator
Author
|
@copilot resolve the merge conflicts in this pull request |
Copilot stopped work on behalf of
Vaibhaav-Tiwari due to an error
June 16, 2026 19:16
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Collaborator
Author
|
@copilot resolve the merge conflicts in this pull request |
Copilot stopped work on behalf of
Vaibhaav-Tiwari due to an error
June 16, 2026 19:47
# Conflicts: # backend/internal/review/review_test.go # backend/internal/storage/sqlite/store/review_store.go # backend/internal/storage/sqlite/store/review_store_test.go
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(session_id, pr_url)so one workspace session can review multiple PRs independently.prUrlselection on review list/trigger APIs; single-PR sessions keep the existing no-selector behavior.Credibility check
Issue #253 is credible on current
origin/main: review storage was unique bysession_id, while PR storage and workspace sessions allow multiple PRs per session. Two details in the issue were stale: the migration is0012_add_review_tables.sqlon main, not0011, andListPRsBySessionis already deterministic byupdated_at DESC. The core problem remained: review trigger still silently collapsed multi-PR sessions unless PR identity became explicit.Tests
go test -count=1 ./internal/review ./internal/storage/sqlite/store ./internal/httpd/...go test -count=1 ./internal/service/review ./internal/daemonnpm --prefix frontend run typecheckgo test ./...was also attempted twice, but timed out after 3 and 5 minutes without emitting a failure in this environment.Closes #253